RetroFed Forum
Your home away from modern life.
refactor rule
Post Reply
AuthorMessage
python lemmy.world python@lemmy.world
Joined: 2023-07-01
Quote

87   Original
WILSOOON programming.dev WILSOOON@programming.dev
Joined: 2024-01-31
#2 · Quote Reply

The pr reviewers have nightmares about

24
four lemmy.zip four@lemmy.zip
Joined: 2024-10-11
#3 · Quote Reply

The pr reviewers have nightmares about

LGTM πŸ‘

9
python lemmy.world python@lemmy.world
Joined: 2023-07-01
#4 · Quote Reply

The pr reviewers have nightmares about

no worries, I''m force pushing to main so there isn't any PR ☺️

19
Victor lemmy.world victorz@lemmy.world
Joined: 2023-11-14
#5 · Quote Reply

no worries, I''m force pushing to main so there isn't any PR ☺️

I hope you fix that exhaustive-deps violation as well! Mustn't leave any deps unexhausted!!

3
python lemmy.world python@lemmy.world
Joined: 2023-07-01
#6 · Quote Reply

I hope you fix that exhaustive-deps violation as well! Mustn't leave any deps unexhausted!!

Oh I know where the violation is, but fixing it in the way my linter wants me too actually breaks a lot of things. I played fast and loose with my useEffect hooks, and now I'm paying the price 🐎
Having completely fucked handmade code is still more fun than using AI tho, so I'm actually looking forward to untangling my mess

2
Victor lemmy.world victorz@lemmy.world
Joined: 2023-11-14
#7 · Quote Reply

Oh I know where the violation is, but fixing it in the way my linter wants me too actually breaks a lot of things. I played fast and loose with my useEffect hooks, and now I'm paying the price 🐎 Having completely fucked handmade code is still more fun than using AI tho, so I'm actually looking forward to untangling my mess

πŸ˜† I hear that, I also enjoy fixing code.

Btw, if you have a useEffect where you don't want to use all its dependent variables, you might be interested in using other built-in reactive hooks. I could hook you up if you're interested. πŸ‘

2
Post Reply
Back to top